Just to confirm, here's what the situation looks like currently, with commands and progress and general code paths:

Thinking about this more this morning I'm inclined to now agree with you that it's ok to explicitly use withProgress and this is a justified use of it outside of commandRunnerWithProgress.

So in terms of changes to make, we remove the codeQL.exportVariantAnalysisResults command, and all uses of it instead call the exportVariantAnalysisResults function directly. We then move the use of withProgress to be inside exportVariantAnalysisResults.

I'm also wondering if we should move the "progress" bits out of commandRunner.ts. They're not actually strictly related, and it would make things like this a bit cleaner. That wouldn't be part of this PR, but I might look at opening another after this to get thoughts on that change.

Current problems/thoughts I'm having with this PR:

• We can't call exportVariantAnalysisResults from VariantAnalysisView because it takes a VariantAnalysisManager as an argument. In the view we only are given a VariantAnalysisViewManager interface to avoid a circular dependency.
  • One option is to add a exportResults method to VariantAnalysisManager that then calls exportVariantAnalysisResults. The main goal of this indirection is to avoid adding more code to VariantAnalysisManager.
• I'm getting a little hung up on the exportSelectedVariantAnalysisResults which lives in export-results.ts which just calls variantAnalysisManager.exportResults which then delegates back to exportVariantAnalysisResults. I'm wondering if we can remove exportSelectedVariantAnalysisResults and merge it with handleExportResults from QueryHistoryManager. But I'm thinking I should just ignore that for this PR.
• We need to keep the telemetry when exporting results from within the view. We're now removing the command so it's even more important.

I've pushed some code but I'm not 100% sure of it. There's other stuff that needs doing but I'll come back later and have another go at this.

Yeah, let's just go for it. We can do more cleanup is followups.

The remaining things I wanted to look at are:

• Should the exportSelectedVariantAnalysisResults method be moved to either the query history or variant analysis managers?
• Should the withProgress method and associated code be moved out of commandRunner.ts?